Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

condition H5F_LIBVER_LATEST and friends on libversion #480

Merged
merged 4 commits into from
May 15, 2018
Merged

condition H5F_LIBVER_LATEST and friends on libversion #480

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9faf879
condition H5F_LIBVER_LATEST and friends on libversion
ggggggggg May 11, 2018
ddc9b25
revert whitespace change
ggggggggg May 11, 2018
1e128a2
remove uneccesary HDF5. from HDF5.libversion
ggggggggg May 14, 2018
77c98e9
Merge pull request #3 from ggggggggg/libver
ggggggggg May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/HDF5.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,15 @@ const H5T_NATIVE_UINT64 = read_const(:H5T_NATIVE_UINT64_g)
const H5T_NATIVE_FLOAT = read_const(:H5T_NATIVE_FLOAT_g)
const H5T_NATIVE_DOUBLE = read_const(:H5T_NATIVE_DOUBLE_g)
# Library versions
const H5F_LIBVER_EARLIEST = 0
const H5F_LIBVER_LATEST = 1
if HDF5.libversion >= v"1.10.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only need libversion not HDF5.libversion, since the constant is defined in the module

const H5F_LIBVER_EARLIEST = 0
const H5F_LIBVER_V18 = 1
const H5F_LIBVER_V110 = 2
const H5F_LIBVER_LATEST = H5F_LIBVER_V110
else
const H5F_LIBVER_EARLIEST = 0
const H5F_LIBVER_LATEST = 1
end

# Object reference types
struct HDF5ReferenceObj
Expand Down Expand Up @@ -2399,7 +2406,7 @@ end
get_datasets(file::HDF5File) -> datasets::Vector{HDF5Dataset}

Get all the datasets in an hdf5 file without loading the data.
"""
"""
function get_datasets(file::HDF5File)
list = HDF5Dataset[]
get_datasets!(list, file)
Expand Down