Add default null reference constructor #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
This is going to conflict, do you want to me to merge this first or second? |
|
I can do it second. I just put up another PR which is going to cause either one of us to need to rebase, so you might as well get the larger rename done first. |
musm
reviewed
Oct 7, 2020
| @@ -1262,7 +1263,7 @@ unpad(s, pad::Integer) = unpad(String(s), pad) | |||
|
|
|||
| # Dereference | |||
| function getindex(parent::Union{File, Group, Dataset}, r::Reference) | |||
| r.r == HOBJ_REF_T_NULL && error("Reference is null") | |||
| r == Reference() && error("Reference is null") | |||
There was a problem hiding this comment.
Is it normal for a no arg constructor to have by default a NULL reference? I suppose it makes sense for this case, since by definition if there is nothing to reference it will be a null reference.
There was a problem hiding this comment.
I was thinking of it more in terms as providing a default zero-initialized data structure. It just so happens to be useful to compare against to indicate whether a reference is valid or not.
|
I don't see a reason against this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a better solution for providing a null reference that can be compared against — trying to fix deprecations in JLD and MAT showed that something like this would be useful.
I know this will have to be rebased after #690 is merged.