Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enabled running tests on pull requests #68

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Apr 21, 2024

  • CI: Updated test workflow from PkgTemplates generated CI workflow
    • Also, added julia-cache and codecov-action actions.
  • Fixed (TIFF) tests on Windows

@stemann stemann mentioned this pull request Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (2ea85e8) to head (6966204).
Report is 53 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
+ Coverage   69.23%   94.93%   +25.70%     
===========================================
  Files           1        1               
  Lines          26       79       +53     
===========================================
+ Hits           18       75       +57     
+ Misses          8        4        -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stemann stemann marked this pull request as ready for review April 21, 2024 08:22
@stemann
Copy link
Contributor Author

stemann commented Apr 21, 2024

Might want to allow failurefix tests on Windows for the time being....

@stemann stemann marked this pull request as draft April 21, 2024 13:05
@stemann stemann force-pushed the feature/ci_fix branch 4 times, most recently from 634186a to 9cadc4c Compare April 21, 2024 13:44
@stemann stemann marked this pull request as ready for review April 21, 2024 13:45
@stemann stemann changed the title CI: Updated test workflow from PkgTemplates generated CI workflow CI: Enabled running tests on pull requests Apr 21, 2024
@stemann
Copy link
Contributor Author

stemann commented Apr 22, 2024

The TIFF tests on Windows were misbehaving since the same file was opened after having been previously opened with mmap: https://github.com/tlnagy/TiffImages.jl/blob/v0.10.0/src/utils.jl#L139

Example of TIFF tests failing on Windows: https://github.com/JuliaIO/ImageIO.jl/actions/runs/8783191936/job/24098831147?pr=69#step:4:497

@stemann
Copy link
Contributor Author

stemann commented Apr 23, 2024

I guess https://github.com/JuliaIO/ImageIO.jl/actions/runs/8783191936 for #69 ran due to dependabot yielding a push event and not just a pull_request event, so adding

on:
  pull_request:

to the CI/test workflow yaml is definitely needed.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@nhz2
Copy link
Member

nhz2 commented Apr 25, 2024

To fix the invalidations test, I think

needs to be changed to version: '1'

@stemann stemann marked this pull request as draft April 26, 2024 13:16
@stemann stemann marked this pull request as ready for review April 26, 2024 13:23
Copy link
Member

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this.

@nhz2 nhz2 merged commit 583389c into JuliaIO:master Apr 26, 2024
18 checks passed
@stemann stemann deleted the feature/ci_fix branch April 26, 2024 17:02
@stemann stemann mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants