Pass old io tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is generally useful, so better to have it in a centralized place
Otherwise users can't call the methods from the command line with typed constructors, e.g., `save(Stream(format"PNG", io), img)`.
Since julia stores arrays in column-major order, which corresponds to "vertical" in the REPL, we need to permute unless the spatialorder property says not to.
|
Failing because it needs JuliaIO/FileIO.jl#38 |
timholy
force-pushed
the
teh/pass_old_io_tests
branch
from
1b7640d
to
3abd63c
Compare
Picked up by readremote tests
timholy
force-pushed
the
teh/pass_old_io_tests
branch
from
3abd63c
to
9c866ee
Compare
|
Nice, a 24% increase in test coverage, too. |
|
reeal nice =) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets all the old Images tests passing basically unmodified