-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #1025
CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #1025
Conversation
Seems like it needs at least: JuliaStats/Clustering.jl#251 |
@SimonDanisch looks like ImageSegmentation needs a compat bump for Clustering 0.15. |
Alright: JuliaImages/ImageSegmentation.jl#93 |
I pushed a change to use isapprox instead of @test imhist(img, 6) == (0.0:0.2:1.2,[0,1,1,1,0,0,1,0]) @test all((≈).(imhist(img, 6), (0.0:0.2:1.2,[0,1,1,1,0,0,1,0]))) |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 722 722
Misses 101 101 ☔ View full report in Codecov by Sentry. |
This pull request changes the compat entry for the
StatsBase
package from0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33
to0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.