Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #1025

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33 to 0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

timholy
timholy previously approved these changes May 2, 2023
@SimonDanisch
Copy link
Member

Seems like it needs at least: JuliaStats/Clustering.jl#251

@palday
Copy link

palday commented May 5, 2023

@SimonDanisch looks like ImageSegmentation needs a compat bump for Clustering 0.15.

@SimonDanisch
Copy link
Member

Alright: JuliaImages/ImageSegmentation.jl#93

@SimonDanisch
Copy link
Member

I pushed a change to use isapprox instead of == to compare the range, which changed from 0.0:0.2:1.2 to 0.0:0.2:1.2000000000000002 in:

@test imhist(img, 6) == (0.0:0.2:1.2,[0,1,1,1,0,0,1,0])
@test all(().(imhist(img, 6), (0.0:0.2:1.2,[0,1,1,1,0,0,1,0])))

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (401d146) 87.72% compared to head (4eb31be) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files           8        8           
  Lines         823      823           
=======================================
  Hits          722      722           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonDanisch SimonDanisch requested a review from timholy May 22, 2023 10:08
@timholy timholy merged commit eadbc9e into master May 22, 2023
7 checks passed
@timholy timholy deleted the compathelper/new_version/2023-05-02-00-19-54-032-04104147996 branch May 22, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants