Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compat for StatsBase to 0.34 #2915

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Conversation

palday
Copy link
Contributor

@palday palday commented May 4, 2023

Description

bump compat for StatsBase to 0.34

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch
Copy link
Member

This doesn't test against 0.34, because of:
JuliaImages/Images.jl#1025
Which fails because of:
JuliaStats/Clustering.jl#251

@palday
Copy link
Contributor Author

palday commented May 5, 2023

I can take care of Clustering, so jut kicked off CI there

@palday
Copy link
Contributor Author

palday commented May 5, 2023

Clustering merged and tagged. @SimonDanisch can you restart CI for Images?

@palday
Copy link
Contributor Author

palday commented May 25, 2023

Makie:
image
CairoMakie:
image

GLMakie:
image

@palday
Copy link
Contributor Author

palday commented May 25, 2023

@SimonDanisch we got it working! do you want a patch bump in this PR or as a follow-up?

@SimonDanisch
Copy link
Member

Nope ;) the release process is a bit more complicated sadly^^

@SimonDanisch SimonDanisch merged commit 9533cec into MakieOrg:master Jun 8, 2023
13 checks passed
@palday palday deleted the patch-1 branch June 8, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants