second attempt with FileIO #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only for ImageMagick, see JuliaIO/ImageMagick.jl#7
@timholy the Imagine port is incomplete because: - don't know file ending - don't know magic byte - would need to implement submodule loading in Fileio (own packige for Imagine?) you should probably just do the changes you feel to be appropriate.
|
Okay besides that SIF doesn't have any tests and Imagine needs to be incorperated in some better way this is good to go, I think! |
|
See #373. The most important addition was deprecations for |
|
Superseded by #373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't include the
grayimchange, because it introduced some conflict I wasn't sure how to fix (different values forpeakvalin edge->Nonmax suppression vertical edge.But there seem to be a different
==operator for Images, so thatImages{Gray{T}} == Images{T}works, so I'm all good for FileIO.