Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typedef <function prototype> #408

Merged
merged 3 commits into from
Dec 17, 2022
Merged

fix typedef <function prototype> #408

merged 3 commits into from
Dec 17, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Dec 16, 2022 •
edited
Loading

JuliaParallel/MPI.jl#693

Fix c function pointer prototypes.

@t-bltg t-bltg marked this pull request as draft December 16, 2022 15:07
@t-bltg t-bltg changed the title rework test fix typedef <function prototype> Dec 16, 2022
@t-bltg t-bltg force-pushed the typedef branch 2 times, most recently from b1947ba to aaf8e86 Compare December 16, 2022 15:08
@t-bltg t-bltg marked this pull request as ready for review December 16, 2022 16:21
@t-bltg
Copy link
Contributor Author

t-bltg commented Dec 16, 2022 •
edited
Loading

@Gnimuc, this seems to fix JuliaParallel/MPI.jl#688.

The new generated file in JuliaParallel/MPI.jl#693 seems to correctly use <some typedefed c function pointer> instead of Ptr{Cvoid}.

EDIT: on hold until JuliaParallel/MPI.jl#693 is green on CI.

A version bump to 0.16.11 following the merge would be appreciated.

@t-bltg t-bltg mentioned this pull request Dec 16, 2022
Merged
@t-bltg t-bltg marked this pull request as draft December 16, 2022 16:47
@t-bltg t-bltg marked this pull request as ready for review December 16, 2022 17:38
@Gnimuc Gnimuc merged commit 8bbef44 into JuliaInterop:master Dec 17, 2022
@Gnimuc
Copy link
Member

Gnimuc commented Dec 17, 2022

As #403 introduced a breaking change, I'm going to tag the next version as 0.17.0.

@t-bltg t-bltg deleted the typedef branch December 17, 2022 10:06
@t-bltg
Copy link
Contributor Author

t-bltg commented Dec 17, 2022

Thanks 🙏

@Gnimuc Gnimuc mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @Gnimuc