Fix segfault on Linux #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
sparse_segfault
branch
from
f805aaa
to
592093e
Compare
|
Thanks! Could you add a test that this patch fixes? |
|
The tests were already failing on Linux, I am not sure what to add |
|
Thank you again! Tests also continue to pass on Windows and this PR fixes linux/osx segfault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to fix the segfault issue. This ends up calling
unsafe_copyto!: https://github.com/JuliaLang/julia/blob/8221c87b09b8456f4fe422ee2d8756a2a2630c7b/base/array.jl#L240which also calls optimized C-function to do the copy so it might be easier and as efficient to call
copyto!instead ofmemcpy.Closes #142