Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of Preferences.jl to configure R_HOME #490

Closed
frankier opened this issue Jun 9, 2023 · 2 comments
Closed

Allow usage of Preferences.jl to configure R_HOME #490

frankier opened this issue Jun 9, 2023 · 2 comments

Comments

@frankier
Copy link
Contributor

frankier commented Jun 9, 2023

From #480

One thing that would be a bit more robust than the current environment variable approach would be to use Preferences.jl. I assume this would be an easier change than allowing super late binding of Rhome, which would allow for it to be set from CondaPkg automatically.

I can have a go at putting together a PR if there is support for this. We could try and fall back to the environment variable approach for backwards compatibility. Would someone be willing to look at such a PR? Perhaps @palday ?

@palday
Copy link
Collaborator

palday commented Jun 9, 2023

I'm not opposed to this per se, but IIRC PythonCall and PyCall also use the ENV variable approach? That's not a strong argument, but more something to note.

One thing to think about is what happens when there is both a Preference and ENV set and they don't agree. That type of inconsistent state can lead to very confusing debugging for users (and developers 😉).

@frankier
Copy link
Contributor Author

Fixed in 31e7859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants