Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MISSING_overlap #6

Open
lbenet opened this issue Apr 8, 2022 · 2 comments
Open

MISSING_overlap #6

lbenet opened this issue Apr 8, 2022 · 2 comments

Comments

@lbenet
Copy link
Member

lbenet commented Apr 8, 2022

Currently, the overlap function is parsed as MISSING_overlap. Could we just parse it as overlap?

In the same spirit, could the overlap tests adhere to the return cases proposed in the implementation here? All return values are Symbols, to have a type-stable function...
@lucaferranti
Copy link
Member

Should overlap return a symbol or enum?

Tbh, performancewise / stylewise it's not fully clear to me when it's better to use one instead of the other

@lbenet lbenet mentioned this issue Apr 23, 2022
Closed
16 tasks
@lbenet
Copy link
Member Author

lbenet commented Apr 23, 2022

See JuliaIntervals/IntervalArithmetic.jl#465 for an implementation using enum's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lbenet @lucaferranti