Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TMSol #117

Merged
merged 11 commits into from
Jun 3, 2021
Merged

Add TMSol #117

merged 11 commits into from
Jun 3, 2021

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented May 27, 2021

This PR proposes the structure TMSol, which currently includes the returned values from the validated integration methods, and includes a recipe for plotting.

@coveralls
Copy link

coveralls commented May 27, 2021

Pull Request Test Coverage Report for Build 880433629

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 37 (2.7%) changed or added relevant lines in 2 files are covered.
  • 50 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.9%) to 64.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/recipe.jl 0 36 0.0%
Files with Coverage Reduction New Missed Lines %
src/promotion.jl 1 2.22%
src/validatedODEs.jl 49 85.52%
Totals Coverage Status
Change from base Build 860448609: 1.9%
Covered Lines: 893
Relevant Lines: 1375

💛 - Coveralls

src/validatedODEs.jl Outdated Show resolved Hide resolved
@lbenet
Copy link
Member Author

lbenet commented May 28, 2021

@mforets Do you have time to review this PR?

@mforets
Copy link
Contributor

mforets commented May 28, 2021

yes, i can do this today

@lbenet lbenet linked an issue May 28, 2021 that may be closed by this pull request
Copy link
Contributor

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the new array interface for TMSol and the plotting functions and it all LGTM. Nice job 🎉

I left some comments that you can safely ignore 😄

src/recipe.jl Outdated Show resolved Hide resolved
src/constructors.jl Outdated Show resolved Hide resolved
src/constructors.jl Outdated Show resolved Hide resolved
src/recipe.jl Show resolved Hide resolved
@lbenet
Copy link
Member Author

lbenet commented Jun 3, 2021

Thanks a lot @mforets for your review. I think it is worth tagging a new minor version, right? Once the version is settled (and tests pass), I'll go ahead and merge.

cc @dpsanders

@mforets
Copy link
Contributor

mforets commented Jun 3, 2021

. I think it is worth tagging a new minor version, right?

yes. thanks

@lbenet lbenet merged commit 297ba71 into master Jun 3, 2021
@lbenet lbenet deleted the lb/TMSol branch November 16, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New struct to contain the solution of an ODE?
3 participants