-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TMSol #117
Conversation
Pull Request Test Coverage Report for Build 880433629Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@mforets Do you have time to review this PR? |
yes, i can do this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the new array interface for TMSol
and the plotting functions and it all LGTM. Nice job 🎉
I left some comments that you can safely ignore 😄
Thanks a lot @mforets for your review. I think it is worth tagging a new minor version, right? Once the version is settled (and tests pass), I'll go ahead and merge. cc @dpsanders |
yes. thanks |
This PR proposes the structure
TMSol
, which currently includes the returned values from the validated integration methods, and includes a recipe for plotting.