-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo times vector change #119
Conversation
@@ -119,7 +119,7 @@ end | |||
# for its = 1:10 | |||
# # Remainder of Picard iteration | |||
# Δ = picard_remainder!(f!, t, x, dx, xxI, dxxI, δI, δt, Δx, Δ0, params) | |||
# | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the other empty character changes are automatic from my text editor, sorry for the noise..
Pull Request Test Coverage Report for Build 884375509
💛 - Coveralls |
I don't think this change is necessary, as I explained in this comment. The current (master) behavior is more consistent with respect to indexing, in such a way that the returned time at step n corresponds to the origin of the domain of the n-th entry of the solution, while before, it was the n-1 time entry. |
but then, the length should be |
i still think that it is unexpected to just see two zeros in the example above instead of |
No description provided.