Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register new package GasModels.jl v0.1.0 #11108

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Sep 8, 2017

Repository: lanl-ansi/GasModels.jl
Release: v0.1.0
cc: @ccoffrin

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@ccoffrin This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@ccoffrin
Copy link
Contributor

ccoffrin commented Sep 8, 2017

cc: @rb004f

@ararslan
Copy link
Member

ararslan commented Sep 9, 2017

Looks like you're doing Pkg.installed checks inside of the package, which in general isn't valid, especially if the module is precompiled. I recommend either separating the integration with other packages into smaller, separate "glue" packages, declaring the integrated packages as actual dependencies, or simply omitting integration until there's a solution in Base Julia for optional dependencies.

@rb004f
Copy link

rb004f commented Sep 11, 2017

We have addressed this comment and updated the release.

@ccoffrin
Copy link
Contributor

cc: @ararslan

@ararslan
Copy link
Member

Great, thanks. The changes look good. You'll have to delete the v0.1.0 tag and tag a new v0.1.0 from the current master in order for Attobot to update this PR.

@attobot
Copy link
Contributor Author

attobot commented Sep 11, 2017

Repository: lanl-ansi/GasModels.jl
Release: v0.1.0
Travis: Travis Build Status
cc: @ccoffrin

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@ccoffrin This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@ararslan
Copy link
Member

ararslan commented Sep 11, 2017

Hm, weird that this works on your Travis builds but not on JuliaCIBot. @aviks, is there some limitation to JuliaCIBot that could be causing the tests to fail there? Is this indicative of a more general problem or is this PR good to go? JuliaCIBot failure aside, this LGTM.

@aviks aviks merged commit b6529c4 into JuliaLang:metadata-v2 Sep 11, 2017
@attobot attobot deleted the GasModels/v0.1.0 branch September 11, 2017 20:21
@ccoffrin
Copy link
Contributor

@ararslan yes it is strange. I have noticed a similar thing on PowerModels.jl, the package evaluator builds are failing due to a segfault in a dependent library, but I cannot seem to replicate it in travis, or any machine that I have locally.

I did make a note of this hear, JuliaCI/PackageEvaluator.jl#175

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants