Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register new package PackageGenerator.jl v0.0.1 #8748

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Apr 8, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
Travis: Travis Build Status
cc: @bramtayl

@attobot
Copy link
Contributor Author

attobot commented Apr 8, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
Travis: Travis Build Status
cc: @bramtayl

@attobot
Copy link
Contributor Author

attobot commented Apr 10, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
Travis: Travis Build Status
cc: @bramtayl

@ararslan
Copy link
Member

How is this different from the functionality provided by PkgDev?

@bramtayl
Copy link
Contributor

Generate a package named package with some nice bells and whistles.
These include:

  • creating a matching github repository
  • activating the repository on travis
  • creating working documentation that
    • automatically syncs
    • tests doctests as part of your package testing suite

@ararslan
Copy link
Member

Seems like it would be worth it to submit a PR to PkgDev to incorporate those features rather than having a separate package.

@bramtayl
Copy link
Contributor

bramtayl commented Apr 10, 2017

I have tried twice, first here JuliaLang/PkgDev.jl#92 then here JuliaDocs/Documenter.jl#416

@bramtayl
Copy link
Contributor

I can keep pushing for the documenter pull request, but

  • This is quite a large chunk of code to review and maintain
  • This package combines the functionality from PkgDev.generate and Documenter.generate. It turns out this is much safer and efficient; in the two phase model, Documenter.generate had to use heuristics to figure out exaxtly what was done in PkgDev.generate

@bramtayl
Copy link
Contributor

bramtayl commented Apr 11, 2017

What do you think?

@ararslan
Copy link
Member

I'll leave it up to @tkelman, master of all things METADATA.

@attobot
Copy link
Contributor Author

attobot commented Apr 11, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
Travis: Travis Build Status
cc: @bramtayl

@bramtayl
Copy link
Contributor

Is the issue here a lack of tests? It can't figure out a good way to test this (I can do it myself; in fact I generated the container for this package using its own code).

@tkelman
Copy link
Contributor

tkelman commented Apr 12, 2017

Why doesn't this include anything related to appveyor?

@tkelman
Copy link
Contributor

tkelman commented Apr 12, 2017

Default generated "no tests" should fail so you don't get a free pass unless you actually test something. JuliaLang/PkgDev.jl#45

@bramtayl
Copy link
Contributor

Why doesn't this include anything related to appveyor?

I thought about including appveyor. The default set up now is just to test on Linux; I've found testing on Windows and OSX much slower and redundant for the simple macro packages I write. I was considering including a multiplatform = true keyword in a future version. If this is a priority, though, I can do this now.

Default generated "no tests" should fail so you don't get a free pass unless you actually test something.

Ok, I can change this. It's set up right now to build a simple documentation page out of the box to show off functionality and documentation isn't built if tests fail.

@ChrisRackauckas
Copy link
Member

I thought about including appveyor. The default set up now is just to test on Linux; I've found testing on Windows and OSX much slower and redundant for the simple macro packages I write. I was considering including a multiplatform = true keyword in a future version. If this is a priority, though, I can do this now.

Most users don't use Linux (probably the vast majority don't). Many things can be OS dependent and the only way to make sure there isn't anything OS dependent is to test (for example, Optim.jl had errors on 32-bit Windows for awhile because it left off AppVeyor tests which ended up showing that hardcoded Int64 dispatches were causing issues). Tests should make sure the package works for most users.

@attobot
Copy link
Contributor Author

attobot commented Apr 20, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
cc: @bramtayl

@attobot
Copy link
Contributor Author

attobot commented Apr 20, 2017

Repository: bramtayl/PackageGenerator.jl
Release: v0.0.1
Travis: Travis Build Status
cc: @bramtayl

@bramtayl
Copy link
Contributor

Ok, the new version includes

  • Full appveyor support
  • Testing on all three platforms
  • Tests that fail by default

@bramtayl
Copy link
Contributor

And also a much more straight-forward way of dealing with ssh_keygen_path

@tkelman tkelman closed this Apr 20, 2017
@tkelman tkelman reopened this Apr 20, 2017
@tkelman tkelman merged commit e4d69c2 into JuliaLang:metadata-v2 Apr 20, 2017
@attobot attobot deleted the PackageGenerator/v0.0.1 branch April 20, 2017 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants