Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Registering CloudGraphs #8892

Merged
merged 5 commits into from May 4, 2017
Merged

Conversation

GearsAD
Copy link
Contributor

@GearsAD GearsAD commented Apr 17, 2017

Repo: CloudGraphs
Travis build: Build Status
Release tag: https://github.com/GearsAD/CloudGraphs.jl/releases/tag/0.0.2

Please let me know if I should make any changes.

Thanks,
Sam

@tkelman
Copy link
Contributor

tkelman commented Apr 18, 2017

You need a license file.

@tkelman
Copy link
Contributor

tkelman commented Apr 18, 2017

LibBSON is missing from REQUIRE, if used directly it should be listed as a dependency rather than assuming it'll be present indirectly

@tkelman
Copy link
Contributor

tkelman commented Apr 25, 2017

should probably remove the 0.0.1 tag's sha1 and requires files since it's missing a dependency

@GearsAD
Copy link
Contributor Author

GearsAD commented Apr 25, 2017

Hi @tkelman,

Thanks for the feedback, I've made the changes:

  • Included the LICENSE
  • LibBSON in REQUIRES

Please let me know if there is anything else I should add.

Thanks,
Sam

@dehann
Copy link
Contributor

dehann commented May 4, 2017

Hi, Travis is passing for CloudGraphs, but FYI the log is showing some unrelated issue with SinglarIntegralEquations v0.2.1.

@tkelman tkelman merged commit f9c2dd6 into JuliaLang:metadata-v2 May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants