remove recompilation dependency check in Pkg.precompile #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check forced packages to recompile if triggers for extensions of their dependencies were added. This could be reproduced the following way: - Add `ColorSchemes` - Precompile - Add `SpecialFunctions` - Notice that `ColorSchemes` now required precompilation again because the extension of SpecialFunctions in ColorVectorSpace is now "active". The last step doesn't make sense because the extension SpecialFunctions doesn't influence ColorSchemes in any way. This check should in theory just be removable since `Base.isprecompiled` should handle checking that all dependencies are valid for the package being precompiled.
IanButterworth
approved these changes
Nov 11, 2023
KristofferC
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> (cherry picked from commit debc38b)
KristofferC
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> (cherry picked from commit debc38b)
KristofferC
added a commit
that referenced
this pull request
Nov 13, 2023
KristofferC
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 13, 2023
Backports a single commit to Pkg (JuliaLang/Pkg.jl#3696) which caused Pkg parallel precompile to sometimes recompile packages that were already compiled.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check forced packages to recompile if triggers for extensions of their dependencies were added.
This could be reproduced the following way:
ColorSchemesSpecialFunctionsColorSchemesnow required precompilation again because the extension of SpecialFunctions inColorVectorSpace(which is a dependency ofColorSchemes) is now "active".The last step doesn't make sense because the SpecialFunctions extension doesn't influence ColorSchemes in any way.
This check should in theory just be removable since
Base.isprecompiledshould handle checking that all dependencies are valid for the package being precompiled.