Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove recompilation dependency check in Pkg.precompile #3696

Merged
merged 2 commits into from Nov 11, 2023
Merged

remove recompilation dependency check in Pkg.precompile #3696

merged 2 commits into from Nov 11, 2023

Commits on Nov 10, 2023

  1. remove recompilation dependency check in Pkg.precompile 

    This check forced packages to recompile if triggers for extensions of their dependencies were added.

This could be reproduced the following way:

- Add `ColorSchemes`
- Precompile
- Add `SpecialFunctions`
- Notice that `ColorSchemes` now required precompilation again because the extension of SpecialFunctions in ColorVectorSpace is now "active".

The last step doesn't make sense because the extension SpecialFunctions doesn't influence ColorSchemes in any way.

This check should in theory just be removable since `Base.isprecompiled` should handle checking that all dependencies are valid for the package being precompiled.
    @KristofferC
    KristofferC committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d19934e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. rm comment & whitespace

    @IanButterworth
    IanButterworth committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7a78108 View commit details
    Browse the repository at this point in the history