Moved reltol and abstol to optional parameters in ode() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjpmarques : Thanks for the PR! This is very much in line with our API discussions for ODE.jl. Would you mind to add the keywords also for |
|
This is an obvious change that makes Sundails closer to the API discussions, without breaking backwards compatibility (for now). |
ivarne
added a commit
that referenced
this pull request
Mar 14, 2014
Moved reltol and abstol to optional parameters in ode()
|
@ivarne : Would have been nice to get |
|
Yes, it would, but I did not think that was a reason to hold this PR. At least when I submit something to a unfamiliar project, it is much more likely that I submit a second one, if the first gets merged quick. |
|
@acroy I added the keyword arguments in |
|
Sorry guys, I should have done this. Thanks. |
|
Nothing to be sorry about. This change was almost a year overdue. |
|
Thanks to both of you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the simplified ode() function interface I ran into problems because the precision was not enough for running my simulation. I changed the code so that the tolerances can now be specified as optional parameters of the function. This doesn't break any code and I think it's common/useful enough to be of used.
I've also included a link to a ijulia notebook that is using this code. I think this would be useful to other users.