Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak is_operator_start_char to not use so heavily nested syntax #208

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

KristofferC
Copy link
Member

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #208 (54285c7) into master (8d2aa01) will increase coverage by 12.94%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #208       +/-   ##
===========================================
+ Coverage   82.53%   95.48%   +12.94%     
===========================================
  Files           4        6        +2     
  Lines         836      841        +5     
===========================================
+ Hits          690      803      +113     
+ Misses        146       38      -108     
Files Coverage Δ
src/utilities.jl 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@KristofferC KristofferC merged commit 9566271 into master Nov 7, 2023
11 checks passed
@oscardssmith oscardssmith deleted the kc/nest_syntax branch November 7, 2023 17:31
@oscardssmith
Copy link
Member

wouldn't it be better to use searchsortedfirst to prevent the allocation? (although that is a fairly minor difference)

@KristofferC
Copy link
Member Author

What allocation?

@oscardssmith
Copy link
Member

searchsorted allocates an array for it's return value.

@KristofferC
Copy link
Member Author

Are you sure?

@oscardssmith
Copy link
Member

oh, never mind. I remembered incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants