Add generic pivoted QR and a bit of restructuring of the qrfacts #13480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we have only had a generic unpivoted QR and therefore we had to check that the elementype was a
BlasFloat
when doing e.g. regressions. With this pr we don't have to do that anymore. We still won't be able to determine the rank generically because it requires some extra functions that I haven't written yet. Therefore rank deficient problems have to wait a bit.I've also moved the actual algorithms into
qrfactUnblocked!
andqrfactPivotedUnblocked!
such that the user facingqrfact!
s are just used for dispatching to the right routine. This makes it easier to call the driver routines directly when necessary instead of usinginvoke
.