Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic pivoted QR and a bit of restructuring of the qrfacts #13480

Merged
merged 1 commit into from
Oct 9, 2015

Conversation

andreasnoack
Copy link
Member

So far, we have only had a generic unpivoted QR and therefore we had to check that the elementype was a BlasFloat when doing e.g. regressions. With this pr we don't have to do that anymore. We still won't be able to determine the rank generically because it requires some extra functions that I haven't written yet. Therefore rank deficient problems have to wait a bit.

I've also moved the actual algorithms into qrfactUnblocked! and qrfactPivotedUnblocked! such that the user facing qrfact!s are just used for dispatching to the right routine. This makes it easier to call the driver routines directly when necessary instead of using invoke.

@tkelman tkelman added the linear algebra Linear algebra label Oct 7, 2015
andreasnoack added a commit that referenced this pull request Oct 9, 2015
Add generic pivoted QR and a bit of restructuring of the qrfacts
@andreasnoack andreasnoack merged commit b9ed89e into master Oct 9, 2015
@andreasnoack andreasnoack deleted the anj/qr branch October 9, 2015 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants