-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename sub/slice -> view #16972
rename sub/slice -> view #16972
Conversation
@@ -5402,14 +5402,14 @@ is raised as an exception in the woken tasks. | |||
notify | |||
|
|||
""" | |||
sub(A, inds...) | |||
view(A, inds...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rst docs too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Okay, looks like this is now working. |
👍 Of course, note that we have multiple view types now: |
Should |
Stefan, I think we should worry about that in v0.6 as we do a more bottom-up refactoring. |
Sounds good to me. |
Any idea why appveyor is failing? |
fixes #16846