-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate no-op transpose fallback instead of error'ing #17374
Conversation
Should probably also add a NEWS.md entry. |
NEWS.md entry added. Thoughts? Thanks! |
I think you rock. Should have realized it was such a simple change. |
Why thank you sir! 😊 Not rocking though: I should have thought to deprecate the method rather than have it throw an error the first time around. Would have saved your and others' time and energy. Whitespace issue fixed. Thanks again! |
Not sure what the Travis assertion failure is about, but most likely unrelated
|
Thanks! |
Uh, this maybe should have waited a bit longer... |
Ah, sorry, I thought this was removing the fallback. |
Ref. #13171 and #17075. cc @tkelman @andreasnoack. Thanks!