Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate no-op transpose fallback instead of error'ing #17374

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jul 11, 2016

Ref. #13171 and #17075. cc @tkelman @andreasnoack. Thanks!

@andreasnoack
Copy link
Member

Should probably also add a NEWS.md entry.

@Sacha0
Copy link
Member Author

Sacha0 commented Jul 11, 2016

Should probably also add a NEWS.md entry.

NEWS.md entry added. Thoughts? Thanks!

@tkelman
Copy link
Contributor

tkelman commented Jul 11, 2016

Thoughts?

I think you rock. Should have realized it was such a simple change.

@Sacha0
Copy link
Member Author

Sacha0 commented Jul 11, 2016

I think you rock.

Why thank you sir! 😊 Not rocking though: I should have thought to deprecate the method rather than have it throw an error the first time around. Would have saved your and others' time and energy.

Whitespace issue fixed. Thanks again!

@tkelman
Copy link
Contributor

tkelman commented Jul 12, 2016

Not sure what the Travis assertion failure is about, but most likely unrelated

julia: /home/travis/build/JuliaLang/julia/src/typemap.c:862: jl_typemap_level_assoc_exact: Assertion `(((jl_value_t*)(((jl_taggedvalue_t*)((char*)(ty) - sizeof(jl_taggedvalue_t)))->header & ~(uintptr_t)15))==(jl_value_t*)(jl_datatype_type))' failed.

@tkelman tkelman merged commit f693323 into JuliaLang:master Jul 12, 2016
@Sacha0 Sacha0 deleted the cterrtodep branch July 12, 2016 11:43
@Sacha0
Copy link
Member Author

Sacha0 commented Jul 12, 2016

Thanks!

@StefanKarpinski
Copy link
Member

Uh, this maybe should have waited a bit longer...

@StefanKarpinski
Copy link
Member

Ah, sorry, I thought this was removing the fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants