readline(s), eachline: make chomp=true a keyword arg
#20203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/chompreadline
branch
2 times, most recently
from
5492124
to
444327e
Compare
tkelman
reviewed
Jan 24, 2017
| """ | ||
| function readline(filename::AbstractString; chomp::Bool=true) | ||
| open(filename) do f | ||
| readline(f, chomp=chomp) |
StefanKarpinski
force-pushed
the
sk/chompreadline
branch
from
444327e
to
7505a5c
Compare
StefanKarpinski
added
the
io
StefanKarpinski
changed the title
chomp a keyword arg, default=truechomp=true a keyword arg
|
Tests passed, then I noticed a problem constructing |
StefanKarpinski
force-pushed
the
sk/chompreadline
branch
from
7505a5c
to
6f677c7
Compare
|
Thanks @mpastell for persisting through the multiple revisions! |
|
@nalimilan Thanks for the support and @StefanKarpinski thanks for finishing this! I have been extremely busy with my actual job the past week. |
I always take a pass through NEWS before a release to make sure everything is clear and included. Can fix this up then. |
|
I have to say, that this is a really pleasant change. Hopefully it won't cause too much trouble, but I think this really is worth it – chomped lines is a much more useful default. |
tkelman
added a commit
that referenced
this pull request
Jan 27, 2017
tkelman
added a commit
that referenced
this pull request
Jan 29, 2017
Fix readlines(::Cmd), was accidentally broken in #20203
ChristianKurz
added a commit
to ChristianKurz/julia-vscode
that referenced
this pull request
Jan 26, 2018
chomp is a keyword argument of readline now and defaults to `true`: [julia #20203](JuliaLang/julia#20203)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @mpastell's excellent work in #19944.