replace export of isleaftype with a more simply-defined isconcrete
#23666
Conversation
| @@ -186,6 +186,7 @@ function find_tvar10930(arg) | |||
| end | |||
| @test find_tvar10930(Vararg{Int}) === 1 | |||
|
|
|||
| const isleaftype = Base._isleaftype | |||
There was a problem hiding this comment.
Couldn't this be written as using Base: _isleaftype? That's a little clearer, IMO.
There was a problem hiding this comment.
No; this file has a lot of uses of the function and I wanted to avoid the churn of changing all of them.
There was a problem hiding this comment.
Okay, thanks for the explanation
ararslan
added
deprecation
base/reflection.jl
Outdated
| ``` | ||
| """ | ||
| isleaftype(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && t.isleaftype) | ||
| isconcrete(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && t.layout != C_NULL) |
There was a problem hiding this comment.
layout != C_NULL merely means that we were able to precompute something about the possible layouts of its concrete subtypes. It's an even more complicated and ill-defined heuristic than isleaftype was.
There was a problem hiding this comment.
Maybe t.layout != C_NULL && t.isleaftype covers it?
There was a problem hiding this comment.
I attempted to pull together a list of the options, and posted it in the original issue to try to avoid forking the original conversation.
JeffBezanson
force-pushed
the
jb/isconcrete
branch
from
4fccb28
to
42101f9
Compare
JeffBezanson
force-pushed
the
jb/isconcrete
branch
from
42101f9
to
a833979
Compare
fixes #17086