fix shuffle! on empty arrays #28727
Merged
fix shuffle! on empty arrays #28727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0.
rfourquet
added
randomness
Merged
KristofferC
reviewed
Aug 19, 2018
|
|
||
| @testset "shuffle[!]" begin | ||
| a = [] | ||
| @test shuffle(a) == a # issue #28727 |
There was a problem hiding this comment.
For the future, putting the issue names in the testset name might be a good idea because you can then see from the test failure the relevant issue.
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0. (cherry picked from commit 728d31d)
staticfloat
pushed a commit
that referenced
this pull request
Aug 24, 2018
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0.
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0. (cherry picked from commit 728d31d)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0. (cherry picked from commit 728d31d)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
shuffle([]) doesn't work anymore since nextpow2(n) has been replaced by nextpow(2, n), where n == 0. (cherry picked from commit 728d31d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shuffle([])doesn't work anymore since nextpow2(n) hasbeen replaced by nextpow(2, n), where n == 0.