Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added seekstart to getpass in base/util.jl (#28828) #28832

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Added seekstart to getpass in base/util.jl (#28828) #28832

merged 1 commit into from
Aug 23, 2018

Conversation

Seelengrab
Copy link
Contributor

See #28828.

@fredrikekre
Copy link
Member

Backport?

@mbauman
Copy link
Member

mbauman commented Aug 22, 2018 •
edited
Loading

Thanks for the PR, and welcome @Seelengrab! Usually it'd be required to add tests alongside each and every patch, but getpass is near-impossible to test in its current state. It both requires a TTY and it requires that TTY to be === stdin. It's an obvious fix so I'm inclined to merge this as-is and work towards tests separately… particularly if it means we can hit a backport into 1.0.1.

To others here: do we need to be requiring that first argument to be a TTY?

@mbauman mbauman added system:windows Affects only Windows security System security concerns and vulnerabilities backport pending 1.0 labels Aug 22, 2018
@KristofferC KristofferC mentioned this pull request Aug 23, 2018
Merged
@KristofferC KristofferC merged commit b6756c5 into JuliaLang:master Aug 23, 2018
KristofferC pushed a commit that referenced this pull request Aug 23, 2018
@Seelengrab @KristofferC
Added seekstart to getpass in base/util.jl (#28828) (#28832)
50c94aa 
(cherry picked from commit b6756c5)
staticfloat pushed a commit that referenced this pull request Aug 24, 2018
@Seelengrab @staticfloat
Added seekstart to getpass in base/util.jl (#28828) (#28832)
9b58648
@Seelengrab Seelengrab deleted the windowsNoGetpass branch August 25, 2018 10:21
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@Seelengrab @KristofferC
Added seekstart to getpass in base/util.jl (#28828) (#28832)
cdd143e 
(cherry picked from commit b6756c5)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@Seelengrab @KristofferC
Added seekstart to getpass in base/util.jl (#28828) (#28832)
a41626c 
(cherry picked from commit b6756c5)
@KristofferC KristofferC added bugfix This change fixes an existing bug and removed backport pending 1.0 labels Sep 27, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@Seelengrab @KristofferC
Added seekstart to getpass in base/util.jl (#28828) (#28832)
dfd4689 
(cherry picked from commit b6756c5)
@KristofferC KristofferC mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug security System security concerns and vulnerabilities system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seelengrab @fredrikekre @mbauman @KristofferC