fix #28833, crash in macros returning certain top-level forms #28882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:lowering
Merged
Keno
reviewed
Aug 25, 2018
src/toplevel.c
Outdated
| } | ||
| assert(jl_is_symbol(gs)); | ||
| jl_get_binding_wr(gm, gs, 0); | ||
| jl_sym_t *gs = (jl_sym_t*)jl_exprarg(ex, i); |
There was a problem hiding this comment.
While you're at it, I don't think we should allow code like this anymore (saying something is a jl_sym_t, when we expect it might be a global ref. Ideally use a jl_value_t here and cast to symbol after the assert.
JeffBezanson
force-pushed
the
jb/fix28833
branch
from
292c0bf
to
519eeb8
Compare
Closed
JeffBezanson
force-pushed
the
jb/fix28833
branch
from
519eeb8
to
653d396
Compare
KristofferC
pushed a commit
that referenced
this pull request
Sep 6, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.