Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tanpi #48575

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Implement tanpi #48575

merged 1 commit into from
Feb 7, 2023

Conversation

bobcassels
Copy link
Contributor

See issue: #48226

tanpi implemented for IEEE Floats and Rational by copying sincospi, and returning sin/cos. For a little extra accuracy for Float16 and Float32, split off sinpi_kernel_wide from sinpi_kernel, so the division can be done on the wide versions of sin and cos.

Copy link
Member

@oscardssmith oscardssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inkydragon inkydragon added the maths Mathematical functions label Feb 7, 2023
@simonbyrne simonbyrne merged commit d5d490f into JuliaLang:master Feb 7, 2023
@simonbyrne
Copy link
Contributor

Thanks!

@bobcassels bobcassels deleted the bc/tanpi branch February 7, 2023 21:14
@fredrikekre fredrikekre added needs news A NEWS entry is required for this change needs compat annotation Add !!! compat "Julia x.y" to the docstring labels Feb 9, 2023
@fredrikekre
Copy link
Member

This should be mentioned in NEWS.md, and have a compat annotation in the docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maths Mathematical functions needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants