Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SparseArrays from system image #48979

Merged
merged 3 commits into from
Mar 19, 2023
Merged

Remove SparseArrays from system image #48979

merged 3 commits into from
Mar 19, 2023

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah added the domain:arrays:sparse Sparse arrays label Mar 11, 2023
@ViralBShah ViralBShah marked this pull request as draft March 11, 2023 21:07
@dkarrasch dkarrasch added the kind:excision Removal of code from Base or the repository label Mar 12, 2023
@ViralBShah
Copy link
Member Author

Failure on master appears is in Sockets, and appears unrelated.

@ViralBShah
Copy link
Member Author

@KristofferC Can we merge?

@ViralBShah ViralBShah closed this Mar 19, 2023
@ViralBShah ViralBShah reopened this Mar 19, 2023
@ViralBShah ViralBShah merged commit 66c5850 into master Mar 19, 2023
@ViralBShah ViralBShah deleted the vs/sparse-nosysimg2 branch March 19, 2023 15:18
@gbaraldi
Copy link
Member

While I think this PR is fine the tests didn't run.

@ViralBShah
Copy link
Member Author

Yes, they didn't run, but they had passed earlier, and they passed locally.

oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Mar 20, 2023
* Remove SparseArrays from system image and add it to cache_stdlibs.jl
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
* Remove SparseArrays from system image and add it to cache_stdlibs.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays:sparse Sparse arrays kind:excision Removal of code from Base or the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants