fix some SCC cycle mistakes #49654
Merged
fix some SCC cycle mistakes #49654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
backport 1.9
oscardssmith
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 9bb0731)
51 tasks
kpamnany
pushed a commit
that referenced
this pull request
Jun 21, 2023
(cherry picked from commit 9bb0731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed cycle was not initialized, which would cause it to disregard methods that only linked back to the current image via a cycle or fail to verify those correctly. And would consider the wrong list of methods when determining if an ambiguity was already covered (making the compiler sometimes do a bit of extra work, or be very slightly too ambitious in very rare hypothetical cases).