Artifacts: pull out a recursive function from a closure to a stand alone function

[KristofferC]

Recursive closures have to be boxed and type inference gives up. This improves the load time of LLVMExtra.jl that calls into Artifacts at runtime.

[staticfloat]

Just to check, it’s enough to add the override file parameter without moving the function definition to be top level, right?

[KristofferC]

I dont actually know. I'll try it out.

[KristofferC]

This suggests that it is not enough:

julia> function f(x)
    g(x) = x == 0 ? 1 : x * g(x-1)
    return g(x)
end;

julia> @code_warntype f(5)
MethodInstance for f(::Int64)
  from f(x) @ Main REPL[2]:1
Arguments
  #self#::Core.Const(f)
  x::Int64
Locals
  g@_3::Core.Box
  g@_4::Union{}
  g@_5::Union{}
Body::Any

[staticfloat]

I did not know that! I’ll have to avoid using interior functions then.

[KristofferC]

I’ll have to avoid using interior functions then.

At least when they are recursive I guess.