-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for hparams #77
Comments
I agree it'd be very useful. TensorBoardLogger does not know about the I'm (unfortunately) on a python's hiatus which will last a while, and don't have time to dedicate to this. |
By the way, I'd be \infty-ely grateful if you found the time to contribute the |
Thanks. Alas, I fear it is outside of my competence, knowledge, or bandwidth at this point. But if I come across an interested grad student/etc. I will point them this way. |
I've started working on this here |
@dangirsh Great! |
@JamieMair as you expressed interest in tackling this... @dangirsh had already started the work, and I pushed it a bit further, so you should start from PR #99 . You should also give a look at my remarks in the review of #87 , which I'm not sure I had addressed fully in #99. IIRC (but you should check) we had already wrapped the functionality , the remaining work is mainly about identifying what quantities/structures can be logged as hparams and design the API that TBLogger should expose, and implement it. If you take #99 you should already be capable of logging hparams, but the api is terrible. |
The 'back-end' is implemented in Most of the work will therefore be in From-end wise, the nice |
Thanks for this! I'll take a look and see what I can do |
I had some time to look at this, right now I've made very few changes, but I've made a list of tasks I need to do. Right now, I have focused on getting the unit tests to pass (they still need a lot of work!). See changes - JamieMair@b54d430 Are there any resources that you recommend for understanding the ProtoBuf code? I am trying to follow the python source https://github.com/tensorflow/tensorboard/tree/master/tensorboard/plugins/hparams, but most of the functionality is hidden behind the |
This issue should be closed as the new API is merged. |
It is very useful to have hyperparameters when looking at logs. i.e. https://pytorch.org/docs/stable/tensorboard.html#torch.utils.tensorboard.writer.SummaryWriter.add_hparams
Is this possible to add to the TensorBoardLogger.jl? Either giving a dictionary or just calling yourself on each dictionary item.
The text was updated successfully, but these errors were encountered: