-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
towards Julia 1.0 support #71
Conversation
To deal with the |
That's equally invalid, just harder for the compiler to catch. You need something similar to https://github.com/JuliaPy/PyCall.jl/pull/267/files#diff-9992319a6cda628c5ad7569c5a03ec96L264 by adding a member for GC safety and store the result of |
is there any timeline for GSL to work on julia 1.0? From a user perspective it is a pretty essential part of scientific julia work... while julia 1.0 is out for developers, I don't feel like it has landed yet for users until GSL or equivalent works. I don't think I have the expertise to do this though, so admittedly and gratefully, I am begging rather than choosing 😄 . |
If someone wants to take this, the first step should probably be to use get the latest version of the binary building using BinaryBuilder.jl |
@simonbyrne https://github.com/giordano/GSLBuilder.jl However it's not complete, yet: build for MacOS fails and I have to investigate what's the issue, and I have to find out how to generate the encrypted key for Travis, BinaryBuilder's wizard fails at that point. Any help would be much appreciated |
Great! Ask on Slack if you need help. |
Also, you should be able to link against the bundled OpenBLAS by adding https://github.com/JuliaLinearAlgebra/OpenBLASBuilder as a dependency |
Fixed by #78. |
This gets us closer (but not all the way) to having GSL.jl working on Julia 1.0. There are still some deprecations related to the old parametric method syntax (I'm hoping FemtoCleaner can handle those) but, more importantly, there's an actual failure due to trying to take the pointer to an immutable here:
GSL.jl/src/28_1_NumericalDifferentiationfunctions.jl
Line 24 in 0d10eed