Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towards Julia 1.0 support #71

Closed
wants to merge 4 commits into from
Closed

Conversation

rdeits
Copy link

@rdeits rdeits commented Aug 16, 2018

This gets us closer (but not all the way) to having GSL.jl working on Julia 1.0. There are still some deprecations related to the old parametric method syntax (I'm hoping FemtoCleaner can handle those) but, more importantly, there's an actual failure due to trying to take the pointer to an immutable here:

@simonbyrne
Copy link
Member

To deal with the pointer_from_objref problem, you could wrap f in a Ref?

@yuyichao
Copy link
Collaborator

To deal with the pointer_from_objref problem, you could wrap f in a Ref?

That's equally invalid, just harder for the compiler to catch.

You need something similar to https://github.com/JuliaPy/PyCall.jl/pull/267/files#diff-9992319a6cda628c5ad7569c5a03ec96L264 by adding a member for GC safety and store the result of cconvert(Ref{Any}) there.

@jagot jagot mentioned this pull request Sep 6, 2018
@AshtonSBradley
Copy link

is there any timeline for GSL to work on julia 1.0? From a user perspective it is a pretty essential part of scientific julia work... while julia 1.0 is out for developers, I don't feel like it has landed yet for users until GSL or equivalent works. I don't think I have the expertise to do this though, so admittedly and gratefully, I am begging rather than choosing 😄 .

@simonbyrne
Copy link
Member

If someone wants to take this, the first step should probably be to use get the latest version of the binary building using BinaryBuilder.jl

@giordano
Copy link
Member

giordano commented Oct 10, 2018

@simonbyrne https://github.com/giordano/GSLBuilder.jl However it's not complete, yet: build for MacOS fails and I have to investigate what's the issue, and I have to find out how to generate the encrypted key for Travis, BinaryBuilder's wizard fails at that point. Any help would be much appreciated

@simonbyrne
Copy link
Member

Great!

Ask on Slack if you need help.

@simonbyrne
Copy link
Member

Also, you should be able to link against the bundled OpenBLAS by adding https://github.com/JuliaLinearAlgebra/OpenBLASBuilder as a dependency

@simonbyrne
Copy link
Member

Fixed by #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants