-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new binary Artifact infrastructure #187
Conversation
@SimonDanisch went ahead and updated your PR, hope you don't mind. Tests look good and are passing. |
What's the current policy with regards to 1.3 updates and binary builder. E.g. should we merge this PR to take advantage of the new infrastructure? |
@giordano thanks for the review! I addressed everything. Let me know if it now has your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if tests are passing!
|
||
[compat] | ||
BinaryProvider = "≥ 0.5.0" | ||
julia = "≥ 0.7.0" | ||
julia = "1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.3 hasn't even been released yet. I don't think we should drop support for 1.0 and later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you propose to use the new infrastructure?
People can still use SpecialFunctions on < Julia 1.3 . This was partly my question #187 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also branch and backport bugfixes to versions compatible with < Julia 1.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you propose to use the new infrastructure?
Don't bother yet, at least until 1.3 is released and we're confident that there won't be necessary bugfixes or anything that apply to previous versions of Julia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway I think it's good to have these early pull requests to test the new framework and maybe let brave users try it if they want 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, don't really expected this to get merged - But I needed it anyways as a fork ;)
I'm going to merge this now that 1.3 is released after tests pass |
Project.toml
Outdated
|
||
[compat] | ||
BinaryProvider = "≥ 0.5.0" | ||
julia = "≥ 0.7.0" | ||
julia = "≥ 1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
julia = "≥ 1.3" | |
julia = "1.3" |
Also need compatibility for the openspecfun version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ≥
unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/JuliaRegistries/General/blob/master/O/OpenSpecFun_jll/Versions.toml
OpenSpecFun_jll = "0.5.3"
for the minimum Ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
≥
means literally any Julia version at or after 1.3.0. Omitting it uses the implicit caret specifier, which gives you only semver-compatible versions. That's important because we don't want this version to be installable on a theoretical future Julia 2.0, for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenSpecFun_jll = "0.5.3" for the minimum Ok ?
Yep that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question, does setting OpenSpecFun_jll = "0.5.3"
allow any version of the package up to and including 1.x
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://julialang.github.io/Pkg.jl/v1/compatibility/. In this case, it fixes OpenSpecFun_jll to 0.5.3, which is good, since we want to ensure we're using a specific version of the openspecfun library.
No description provided.