Fix a bug in coeff2 and add a test #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 92.41% 92.01% -0.40%
==========================================
Files 12 12
Lines 2794 2806 +12
==========================================
Hits 2582 2582
- Misses 212 224 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
devmotion
approved these changes
Feb 21, 2022
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
approved these changes
Feb 22, 2022
andreasnoack
added
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eta < 1000.0branch was missing the(-12.0*eta)denominator. I've also added some line breaks to make it easier to read the coefficients. This fixes part of #390.