Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify Amos exception #46

Merged
merged 2 commits into from
Aug 22, 2017
Merged

simplify Amos exception #46

merged 2 commits into from
Aug 22, 2017

Conversation

musm
Copy link
Contributor

@musm musm commented Aug 22, 2017

No description provided.

simonbyrne
simonbyrne approved these changes Aug 22, 2017
View reviewed changes
Copy link
Member

@simonbyrne simonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get rid of AmosException eventually, but this seems like a net improvement.

@musm
Copy link
Contributor Author

musm commented Aug 22, 2017

True, we can at least get rid of some of the errors in favor of Julia equivalents.

@simonbyrne
Copy link
Member

Actually, I'm not sure there are sufficient ones. e.g. OverflowError is mainly used for integer overflow (the floating point equivalent would be to return Inf (or possibly NaN if part of an intermediate computation)

@musm
Copy link
Contributor Author

musm commented Aug 22, 2017

What about ArgumentError for e.g. id == 1 ?

@simonbyrne
Copy link
Member

That seems reasonable.

@musm musm merged commit cc7f9aa into master Aug 22, 2017
@musm musm deleted the musm-patch-1 branch August 22, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@musm @simonbyrne