Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the same required arguments for all the LineSearches #117

Closed
anriseth opened this issue Jun 5, 2018 · 3 comments
Closed

Have the same required arguments for all the LineSearches #117

anriseth opened this issue Jun 5, 2018 · 3 comments

Comments

@anriseth
Copy link
Collaborator

anriseth commented Jun 5, 2018

@antoine-levitt has suggested that we require all the line search algorithms to have the same required arguments.

(ls::LineSearch)(ϕ, dϕ, ϕdϕ,alpha0::T, ϕ_0, dϕ_0) where T

That way, we don't need a perform_linesearch wrapper like the one I added to the custom optimizer example.
@pkofod
Copy link
Member

pkofod commented Jun 5, 2018

Suggested where? I agree though.

@anriseth
Copy link
Collaborator Author

anriseth commented Jun 5, 2018

Suggested on the Optim gitter channel ;)

@anriseth
Copy link
Collaborator Author

anriseth commented Jun 6, 2018

Closed via #121

@anriseth anriseth closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anriseth @pkofod