Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetCDF_jll] Potential dependency on AWSCRT (windows) #6192

Open
Alexander-Barth opened this issue Feb 3, 2023 · 2 comments
Open

[NetCDF_jll] Potential dependency on AWSCRT (windows) #6192

Alexander-Barth opened this issue Feb 3, 2023 · 2 comments

Comments

@Alexander-Barth
Copy link
Contributor

Alexander-Barth commented Feb 3, 2023

The NetCDF package can optionally depend on the AWS S3 SDK (which is available in Yggdraslil but not for Windows). Would it be possible that NetCDF depend on AWSCRT without loosing the Windows build?

Surprisingly the build script include some windows specific patches:

https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AWSCRT/bundled/patches/aws-c-common.patch
https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AWSCRT/build_tarballs.jl#L63

and Windows seems to be supported by upstream, but the build script excludes it as a supported platform:
https://github.com/JuliaPackaging/Yggdrasil/blob/master/A/AWSCRT/build_tarballs.jl#L220

I am wondering if there any particular reason for that? Maybe @Octogonapus knows?

@Alexander-Barth Alexander-Barth changed the title Potential dependency on AWSCRT (windows) [NetCDF_jll] Potential dependency on AWSCRT (windows) Feb 3, 2023
@Octogonapus
Copy link
Contributor

It is because the Windows build is not fully working. The patches fix some of the problems, just not all of them. It also wasn't a priority for my use of AWSCRT, so I disabled it in the interest of time.

You are right that Windows support should be possible. I currently don't have time to work on it, though.

@Alexander-Barth
Copy link
Contributor Author

Thanks a lot @Octogonapus for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants