-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HiGHS] add explicit Zlib_jll dependency #8071
Conversation
H/HiGHS/highs_common.jl
Outdated
@@ -4,7 +4,7 @@ using BinaryBuilder, Pkg | |||
|
|||
name = "HiGHS" | |||
|
|||
version = v"1.6.0" | |||
version = v"1.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream version didn't change though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah upstream hasn't released a new version yet. But I also thought that you couldn't add new dependencies to a +1
version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding is actually fine, it's removing, or changing compat bounds, that doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay cool. I reverted to 1.6.0
* [HiGHS] add Zlib_jll as explicit dependency * [HiGHSStatic] add explicit Zlib_jll dependency * Update version * Apply suggestions from code review * Apply suggestions from code review * Update H/HiGHS/highs_common.jl
x-ref jump-dev/HiGHS.jl#199
TODO:
Zlib
was correctly found