[HiGHS] add explicit Zlib_jll dependency #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Feb 7, 2024
odow
commented
Feb 7, 2024
odow
commented
Feb 7, 2024
odow
commented
Feb 7, 2024
|
Looks like this worked
|
giordano
reviewed
Feb 7, 2024
H/HiGHS/highs_common.jl
Outdated
| @@ -4,7 +4,7 @@ using BinaryBuilder, Pkg | |||
|
|
|||
| name = "HiGHS" | |||
|
|
|||
| version = v"1.6.0" | |||
| version = v"1.6.1" | |||
There was a problem hiding this comment.
The upstream version didn't change though?
There was a problem hiding this comment.
Yeah upstream hasn't released a new version yet. But I also thought that you couldn't add new dependencies to a +1 version?
There was a problem hiding this comment.
Adding is actually fine, it's removing, or changing compat bounds, that doesn't work
There was a problem hiding this comment.
Ah okay cool. I reverted to 1.6.0
odow
commented
Feb 7, 2024
grasph
pushed a commit
to Moelf/Yggdrasil
that referenced
this pull request
Jul 1, 2024
* [HiGHS] add Zlib_jll as explicit dependency * [HiGHSStatic] add explicit Zlib_jll dependency * Update version * Apply suggestions from code review * Apply suggestions from code review * Update H/HiGHS/highs_common.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref jump-dev/HiGHS.jl#199
TODO:
Zlibwas correctly found