-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HiGHSstatic] remove Zlib dependency #8409
Conversation
If you want to statically link ZLib, then I think you can try adding
to the CMake invocation when you want the static library (and either setting it to This will also require a newer CMake (3.24+), so you will want to add a new dependency as well to get a newer version than what we use by default (this will just pull in the most recent CMake version, which is currently 3.28):
|
cd $WORKSPACE/srcdir/HiGHS | ||
|
||
# Remove system CMake to use the jll version | ||
apk del cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to remember to add HostBuildDependency(PackageSpec(; name="CMake_jll")),
to `HiGHS_jll.jl the next time I rebuild it, but that's okay. I'll likely find this comment when I go searching if I forget.
Looking at the artifacts for the Linux x86_64 build, the |
Let me just check the osx build |
Good by me:
|
Closes #8408
Let's just remove this for now. It was added in #8071, and it's only needed for cases where the user wants to read compressed MPS files.