Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm: srun being passed a Julia option? #75

Closed
sbromberger opened this issue Aug 3, 2017 · 4 comments
Closed

Slurm: srun being passed a Julia option? #75

sbromberger opened this issue Aug 3, 2017 · 4 comments

Comments

@sbromberger
Copy link

On Julia 0.6, latest release of ClusterManagers:

julia> using ClusterManagers

julia> addprocs(SlurmManager(2), partition="pdebug", t="00:5:00")
srun: unrecognized option '--enable-threaded-blas=false'
Try "srun --help" for more information
@sbromberger
Copy link
Author

I put a println in to see the srun command; it returned

srun command: `srun -J julia-203893 -n 2 -o job%4t.out -D /g/g17/seth/.julia/v0.6/ClusterManagers/src -t 00:5:00 --partition=pdebug --enable-threaded-blas=false /g/g17/seth/dev/julia/bin/julia --worker 8DF...u`

@amitmurthy
Copy link
Contributor

Can you test if this works?

--- a/src/slurm.jl
+++ b/src/slurm.jl
@@ -12,11 +12,10 @@ function launch(manager::SlurmManager, params::Dict, instances_arr::Array,
         exehome = params[:dir]
         exename = params[:exename]
         exeflags = params[:exeflags]
-        p = copy(params)
-        p = delete!(p, :dir)
-        p = delete!(p, :exename)
-        p = delete!(p, :exeflags)
-        p = delete!(p, :topology)
+
+        stdkeys = keys(Base.Distributed.default_addprocs_params())
+        p = filter((x,y) -> !(x in stdkeys), params)
+
         srunargs = []
         for k in keys(p)
             if length(string(k)) == 1

@sbromberger
Copy link
Author

Will test now. It was easy to fix by just delete!ing the :enable_threaded_blas symbol but that is probably not what we wanted to do.

@sbromberger
Copy link
Author

It works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants