Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowerbound to Julia 1.0 and add Project.toml #106

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

jpsamaroo
Copy link
Member

Added Project.toml and excluded Manifest.toml in gitignore
Bumped Julia version to 1.0 in REQUIRE

Hopefully the [compat] line is correct too.

Added Project.toml and excluded Manifest.toml in gitignore
Bumped Julia version to 1.0 in REQUIRE
@jpsamaroo
Copy link
Member Author

Any objections to what I've done here? We'll need a Project.toml if we're to register new versions in General, and this makes working with a dev'd Dagger project much easier to work with. So I'd like to get this PR in as soon as possible.

@aviks
Copy link

aviks commented Jun 13, 2019

LGTM

@andreasnoack andreasnoack merged commit 0da2ed4 into JuliaParallel:master Jun 13, 2019
@jpsamaroo
Copy link
Member Author

Thanks! Would now be a good time to tag a minor/major release of Dagger?

@andreasnoack
Copy link
Member

Yes. Please check that JuliaDB still works with these changes before making the release.

@jpsamaroo
Copy link
Member Author

I already did a local run of the JuliaDB tests on Dagger master about a month ago, but I would like at least 1 more person to test that as well, just in case. I was hoping to recruit such a soul during the JuliaCon hackathon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants