Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI plan rendering #157

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Improve UI plan rendering #157

merged 5 commits into from
Nov 4, 2020

Conversation

jpsamaroo
Copy link
Member

@jpsamaroo jpsamaroo commented Oct 29, 2020 •
edited
Loading

Will close #156

Todo:

  • Make visualization quick and easy to do
  • Reduce information within nodes to make them smaller
  • Move node information to outside shape (note: I ended up removing some information for now)
  • Color nodes with unique color per processor
  • Color the edges with a gradient from source to destination
  • Widen node borders for longer computations
  • Widen the edges for longer transfers
  • Change node shape according to processor type
  • Color and shape legend
  • Dispatch for pretty-printing argument nodes (and hopefully coloring Chunk with the owning processor)
  • Show arg -> Thunk network timings

@coveralls
Copy link

coveralls commented Oct 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 63.914% when pulling edcb640 on jps/easy-log-plan into f2d3c53 on master.

vchuravy
vchuravy reviewed Oct 29, 2020
View reviewed changes
src/compute.jl Outdated Show resolved Hide resolved
@jpsamaroo
Vastly improve graph rendering
641280e 
Use unique colors for unique processors
Use unique shapes for each type of processor
Render Comm and Move times for argument-to-thunk edges
@jpsamaroo
Document Context.log_file
7dfd10f
@jpsamaroo jpsamaroo marked this pull request as ready for review November 4, 2020 20:38
@jpsamaroo jpsamaroo merged commit 9e696f7 into master Nov 4, 2020
@jpsamaroo jpsamaroo deleted the jps/easy-log-plan branch November 4, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
data movement enhancement scheduler ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Graph coloring and other visualization improvements
3 participants
@jpsamaroo @coveralls @vchuravy