Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package in two, to separate building profile protos from visualizing profiles #72

Open
NHDaly opened this issue Oct 18, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@NHDaly
Copy link
Member

NHDaly commented Oct 18, 2022

Problem

Proposal

Some users don't actually need pprof_jll as a dependency (for example, at RAI). The parts of PProf.jl that we do need, are the parts that convert a profile into the pprof protobuf format. The pprof_jll is there for users to be able to visualize the profiles. We only use PProf for generating protos, as part of https://github.com/JuliaPerf/PerformanceProfilingHttpEndpoints.jl.

What this suggests to me is that probably we should split the PProf package in two (in the same repo):

  • PProf.jl (Visualization + generating profiles), and
  • PProfProducer, or PProfConverter, or PProfCore, or something like that, which is a package that just provides the profile => pprof.pb.gz conversion functionality.

Then RAI could depend only on the latter, and thus we wouldn't depend on graphviz_jll.

@NHDaly NHDaly added enhancement New feature or request help wanted Extra attention is needed labels Oct 18, 2022
@NHDaly
Copy link
Member Author

NHDaly commented Oct 18, 2022

@quinnj for triage :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant