Add edge labels #65

JackDevine · 2019-06-14T04:05:09Z

The edgelabels kwarg accepts either a dictionary, a vector or a matrix describing the edge labels.

If you use a vector or matrix, then either missing, false, nothing, NaNor "" values will not be displayed.

The labels are 3/4 of the way along the given edge in the direction of the edge. We could also have the ability to say how far along the edge the labels are.

using LightGraphs
using GraphRecipes
using Plots
g = WheelGraph(5)
edgelabel = Any["$(i)_$(j)" for i in 1:size(adjacency_matrix(g))[1], j in 1:size(adjacency_matrix(g))[2]]
edgelabel[3] = ""
plot(g, names=[1,2,3,4,5], edgelabel=edgelabel)

Fixes #54

mkborregaard

Nice as a first approximation.
I think we'd like the points to follow the line as it curves, but be next to it not on it, preferably so that the text is always on the outside of the curve. I don't know if directed edges always curve counterclockwise (or clockwise) given the current weak support for directed edges, but I think they should. That would make it much more transparent which curve the labels belong to. I think your example also shows that the directed_curve function could take some tweaking to get rounder edges.

Why not make the default to have the labels at 50% rather than at the end? Not sure here.

Does this code also work if the annotations / edgelabels have been wrapped in a Plots.Font object? That's the Plots way of applying fonts, sizes, colors etc to the edgelabels. I don't particularly like that interface, btw, so might be nice to think of alternatives.

mkborregaard · 2019-06-14T20:35:06Z

src/graphs.jl

@@ -365,13 +371,35 @@ end
                    _3d && push!(zseg, z[si], z[di], NaN)
                    push!(l_wg, wi)
                end
+            if typeof(edgelabel) == Dict


Do you mean if edgelabel isa Dict?

Good point, thanks.

mkborregaard · 2019-06-14T20:35:28Z

src/graphs.jl

@@ -365,13 +371,35 @@ end
                    _3d && push!(zseg, z[si], z[di], NaN)
                    push!(l_wg, wi)
                end
+            if typeof(edgelabel) == Dict
+                if edge_label_exsists(edgelabel, (si, di))


typo shound be exists

Wow, that is embarassing. I am really bad without a spellchecker.

mkborregaard · 2019-06-14T20:36:07Z

src/graphs.jl

+        edge_label_array = Vector{Tuple}()
+        if typeof(edgelabel) <: AbstractArray
+            edgelabel = vec(edgelabel)
+            (edge_label_array_size = round(Int, sqrt(length(edgelabel))))


Why is this in brackets? And what's the thinking exactly?

The brackets are a mistake from some sort of copy/paste job. This piece of code makes it so that the user can pass in a matrix and the code will still work. Now that I think of it, I think that we should go the other way round. If the user passes in a matrix, then we don't do any conversion and if they pass in a vector, then we reshape into a matrix. That way I wouldn't have to do any of the confusing LinearIndices business that I go through on lines 389 and 393.

mkborregaard · 2019-06-14T20:38:43Z

src/graphs.jl

+                        push!(edge_label_array,
+                              (0.25xsi + 0.75xdi, 0.25ysi + 0.75ydi,
+                               string(edgelabel[LinearIndices((1:edge_label_array_size, 1:edge_label_array_size))[si, di]])))
+                    else  # TODO: Make 3d work.


yeah, annotations are tricky in 3d

mkborregaard · 2019-06-14T20:40:02Z

src/utils.jl

@@ -119,6 +119,16 @@ function arcdiagram_limits(x, source, destiny)
    (xmin-margin, xmax+margin), ylims
 end

+edge_label_exsists(label_list::Dict, inds::Tuple) = haskey(label_list, inds)


same typo here and below

mkborregaard · 2019-06-14T20:42:38Z

src/graphs.jl

+                if edge_label_exsists(edgelabel, (si, di))
+                    if dim == 2
+                        push!(edge_label_array,
+                              (0.25xsi + 0.75xdi, 0.25ysi + 0.75ydi, string(edgelabel[(si, di)])))


I don't know this code super well, but shouldn't this be xpts and ypts so the labels follow along the curve?

Yes, that will make things look a little nicer.

JackDevine · 2019-06-15T05:19:58Z

Thanks for the in depth review!

I think we'd like the points to follow the line as it curves, but be next to it not on it, preferably so that the text is always on the outside of the curve.

Agreed.

I don't know if directed edges always curve counterclockwise (or clockwise) given the current weak support for directed edges, but I think they should.

They curve randomly:

GraphRecipes.jl/src/graphs.jl

Line 350 in e3180a8

xpt, ypt = if method != :chorddiagram

Deciding on either clockwise or anticlockwise sounds better to me.

Why not make the default to have the labels at 50% rather than at the end? Not sure here.

TikzGraphs and GraphPlots have their labels further along the edge than 50%. Although, maybe we should make that an opt in property.

Does this code also work if the annotations / edgelabels have been wrapped in a Plots.Font object?

No, that does not work right now. I will make that work soon.

JackDevine · 2019-06-19T03:44:54Z

I have gone through all of the points made, although there are some things that I should point out.

I have made it so that edges curve in a given direction, not randomly, see graphs.jl line 369
I still cannot get 3d to work
I have added a new kwarg called edgelabel_offset that allows the user to say how far they want the labels from the edges
Edge labels are now halfway between the source and destiny nodes
I have not made the labels work with Plots.Font. In fact, the kwarg names does not work with Plots.Font either. I have simply made it so that the edgelabels use the kwarg fontsize to get their fontsize, just like the nodelabels do.

mkborregaard · 2019-06-19T05:28:18Z

Sounds great 👍 Do you have an example plot?

JackDevine · 2019-06-19T06:18:24Z

Example plot:

using LightGraphs
using GraphRecipes
using Plots
n = 5
g = WheelGraph(n)
edgelabel = Any["$(i)_$(j)_hello" for i in 1:size(adjacency_matrix(g))[1], j in 1:size(adjacency_matrix(g))[2]]
# edgelabel = Dict()
# for i in 1:n
#     for j in 1:n
#         edgelabel[(i, j)] = string(i, "_", j, "hello_long_name")
#     end
# end
graphplot(g, names=collect(1:n), curvature_scalar=0.1, edgelabel=edgelabel, fontsize=7,
          edgelabel_offset=0.05)

If you uncomment the commented bit, then you get the same result, just that edgelabel is a Dict.

One thing that I forgot in my list above is that the logic of the program is that if the user passes a vector or a matrix, then graphplot converts to a Dict. Although, you probably already worked that out.

mkborregaard

This looks great

JackDevine · 2019-06-19T08:24:10Z

Thanks for your help @mkborregaard !

I will leave this open for a little longer on the off chance that anyone else wants to comment.

ManCornet · 2023-05-04T13:03:23Z

Hello everyone !

I've recently noticed a strange behaviour when I set the curves argument of the graphplot function to false. In this case, the edgelabel_offset does not work. Is it normal ?

Thank you !

Manon

JackDevine added 5 commits June 11, 2019 14:09

Add method plot(g::AbstractGraph)

55a0e67

Fixes #54

Merge branch 'plot_method'

5d4eaf9

Merge branch 'master' of https://github.com/JuliaPlots/GraphRecipes.jl

a6b388f

Add edge labels

ec5ff8a

Make sure that labels are converted into strings

67de9c5

mkborregaard reviewed Jun 14, 2019

View reviewed changes

JackDevine mentioned this pull request Jun 15, 2019

plot directed graph #55

Closed

Minor tweaks

56aab0e

mkborregaard approved these changes Jun 19, 2019

View reviewed changes

JackDevine merged commit e219601 into JuliaPlots:master Jun 19, 2019

JackDevine mentioned this pull request Jun 29, 2019

Add edge labels #58

Closed

JackDevine mentioned this pull request Aug 11, 2019

Add AbstractTrees plotting #80

Merged

JackDevine mentioned this pull request Jan 4, 2020

New release #87

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add edge labels #65

Add edge labels #65

JackDevine commented Jun 14, 2019

mkborregaard left a comment

mkborregaard Jun 14, 2019

JackDevine Jun 15, 2019

mkborregaard Jun 14, 2019

JackDevine Jun 15, 2019

mkborregaard Jun 14, 2019

JackDevine Jun 15, 2019

mkborregaard Jun 14, 2019

mkborregaard Jun 14, 2019

mkborregaard Jun 14, 2019

JackDevine Jun 15, 2019

JackDevine commented Jun 15, 2019 •

edited

Loading

JackDevine commented Jun 19, 2019

mkborregaard commented Jun 19, 2019 •

edited

Loading

JackDevine commented Jun 19, 2019

mkborregaard left a comment

JackDevine commented Jun 19, 2019

ManCornet commented May 4, 2023

Add edge labels #65

Add edge labels #65

Conversation

JackDevine commented Jun 14, 2019

mkborregaard left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JackDevine commented Jun 15, 2019 • edited Loading

JackDevine commented Jun 19, 2019

mkborregaard commented Jun 19, 2019 • edited Loading

JackDevine commented Jun 19, 2019

mkborregaard left a comment

Choose a reason for hiding this comment

JackDevine commented Jun 19, 2019

ManCornet commented May 4, 2023

JackDevine commented Jun 15, 2019 •

edited

Loading

mkborregaard commented Jun 19, 2019 •

edited

Loading