Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix compatibility with julia v0.6 #14

Closed
wants to merge 6 commits into from

Conversation

rdeits
Copy link
Contributor

@rdeits rdeits commented May 30, 2017

Includes scary workaround for #13

as with JuliaPolyhedra/Polyhedra.jl#24 this bumps the required Julia version up to v0.6 since the newest GeometryTypes and StaticArrays both require v0.6.

@codecov
Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #14 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   73.34%   73.28%   -0.07%     
==========================================
  Files          11       11              
  Lines         818      816       -2     
==========================================
- Hits          600      598       -2     
  Misses        218      218
Impacted Files Coverage Δ
src/operations.jl 76.15% <ø> (-0.47%) ⬇️
src/mytype.jl 53.52% <ø> (ø) ⬆️
src/CDDLib.jl 100% <ø> (ø) ⬆️
src/matrix.jl 82.67% <100%> (+0.08%) ⬆️
src/polyhedron.jl 68.66% <100%> (ø) ⬆️
src/polyhedra.jl 94.44% <100%> (ø) ⬆️
src/lp.jl 98.73% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc04e60...69895ca. Read the comment docs.

@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage decreased (-0.07%) to 73.284% when pulling 5f8c2fc on rdeits:fix-0.6 into bc04e60 on JuliaPolyhedra:master.

@rdeits rdeits changed the title Fix compatibility with julia v0.6 WIP: Fix compatibility with julia v0.6 May 30, 2017
@blegat
Copy link
Member

blegat commented Jun 4, 2017

Superseded by #15

@blegat blegat closed this Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants