-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for d=0 in lazy sets #49
Comments
- turned shorthand function style into `function ... end` blocks (except for constructors) - renamed `is_contained` -> `∈` - checked #49 - minor doc fixes
I reviewed this in #73.
For the following types we have to revise:
@mforets: Do you agree with these changes? For the unit tests it will be helpful to have #68. |
- turned shorthand function style into `function ... end` blocks (except for constructors) - renamed `is_contained` -> `∈` - checked #49 - minor doc fixes
In some set operations we specifically say that the results depends on the wrapped sets, e.g.
In other cases the check is explicit and an assertion error is returned, e.g. for Bloating,
In other cases as mentioned in this comment the operation returns a hard-coded value eg. the origin. |
I think consistency across different types for this corner case would be nice for the next major release, so I'm adding this to the v2.0 milestone. |
We should review that for
d=0
the support vector returns a point in the set, or to consider the special cases that raise an error otherwise.The text was updated successfully, but these errors were encountered: