Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2417 - Specialize concrete minkowski sum for singletons #2418

Merged
merged 2 commits into from
Nov 17, 2020
Merged

#2417 - Specialize concrete minkowski sum for singletons #2418

merged 2 commits into from
Nov 17, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Nov 16, 2020

Closes #2417.

schillic
schillic approved these changes Nov 16, 2020
View reviewed changes
src/ConcreteOperations/minkowski_sum.jl Outdated Show resolved Hide resolved
schillic
schillic approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately this could actually be the way to implement operations for all set types: have a single minkowski_sum method with the error message and then do the real work in _minkowski_sum methods.

@mforets mforets merged commit f827f7e into master Nov 17, 2020
@mforets mforets deleted the mforets/2417 branch November 17, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concrete Minkowski sum of Singletons
2 participants
@mforets @schillic