Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Oceananigans v0.87.2 #90926

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 9e8cae18-63c1-5223-a75c-80ca9d6e9a09
Repo: https://github.com/CliMA/Oceananigans.jl.git
Tree: 8746c619e15950de59160b2d99e61961cfa57fcc

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
JuliaRegistrator referenced this pull request in CliMA/Oceananigans.jl Sep 6, 2023
…formulation + other fixes (#3122)

* Reorganize immersed boundary implementation + Field for bottom_height

* Better comment in set!

* Update manifest

* Move around imports

* Update windy convection validation

* More sophisticated windy convection

* Fix CATKE problems with tuples

* Better abstraction than truefunc and cosmetic change to conditional operation

* Cosmetic change to field

* Minor change to conditional fluxes

* Fix immersed reductions so they dont evaluate inactive nodes

* Formatting

* Extend grid fitted functions to all IBG

* Cosmetics

* Improve height above bottom and depth

* CATKE improvements for bottom boundary layers

* Improve ri-based for immersed boundaries

* Cosmetics for vertically implicit diffusion

* Fix show

* Update to homogeneous windy convection

* Maybe fix immersed boundaries with Field bottom-height

* Simplify via adapt

* Simpler reductions for bottom_height

* Interior to parent

* Update src/Fields/field.jl

* Update src/Fields/field.jl

Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>

* Use max in mixing length

* Add output for ZeroField

* Better JLD2 output writer

* Add backward compatibility for FieldTimeSeries

* Fix bug in entrainment diffusivity for ri-based

* Cell centered dissipation length

* Bug in vertically-implicit diffusion?

* Cosmetic improvements

* Fix vertically implicit solver for general grids plus better notation

* Cosmetics

* Hmm

* Add missing import for CATKE

* Add tests

* More readable

* Help readability in ri-based diffusivity

* Dont test RiBased generically

* add note about convention in BatchedTridiagonalSolver doc

* clarifications

* add remark about different notation in Press

* clarifications

* minor beautification tweaks

* Add back Manifest from main

* Delete function tridiagonal solver tests

* New numerics, new defaults

* Implement time-smoothing of the buoyancy flux

* fix doctest

* Fix sign error in explicit dissipation

* Fix dissipation call signature and better name for dissipation rate

* bugfix

* Refactor CATKE parameters

* Fix GPU errors

* Updates

* Bugfix

* Use precise TKE terms

* Commit to nonconservative TKE equation but add comments

* Update free parameters and add comments

* Go back to conservative formulation

* New defaults based on defaults in #3090

* Fix shear production signature

* Bump convective entrainment parameter

* Change heterogeneous windy convection to an upwelling example

* Overhaul baroclinic adjustment example

* Remove messages during `record`

* Upwelling validation tests

* Clean up batched tridiagonal solver and vertically implicit solver

* Fix bug in batched tridiagonal solver

* Try to fix multi region immersed boundary issue

* Hopefully fix immersed boundary grid constructor

* Another fix

* add catke preprint

* remove warning; add ref to catke preprint

* some code cleanup

* Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl

Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>

* Refactor unit tests

* Generalize regridding for lat-lon

* Add newline

* Update test_turbulence_closures.jl

* rework IBG and MRG

* Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl

* small bugfix

* remove multiregion ibg with arrays for the moment

* bugfix

* little cleaner

* fixed tests

* see what the error is

* dummy commit

* Allow tke and tracer diffusivity to be limited indepedent of viscosity

* small bugfix

* why would this specifically not work?

* test_broken for broken tests

* other broken tests

* Update Project.toml

---------

Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Simone Silvestri <33547697+simone-silvestri@users.noreply.github.com>
Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch September 6, 2023 18:52 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 2463880 into master Sep 6, 2023
14 of 15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-oceananigans-9e8cae18-v0.87.2-c090128d9e branch September 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants